Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ubuntu installer fixes #685

Merged
merged 4 commits into from
Jan 26, 2023
Merged

Ubuntu installer fixes #685

merged 4 commits into from
Jan 26, 2023

Conversation

shitwolfymakes
Copy link
Member

@shitwolfymakes shitwolfymakes commented Jan 26, 2023 •
edited
Loading

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change.

Fixes the following:

Please note that PATH changes won't propagate to new bash shells until after a reboot

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

  • Ubuntu 18.04
  • Ubuntu 20.04
  • Debian 10
  • Debian 11
  • Docker
  • Other (Please state here)

Checklist:

  • I have submitted this PR against the v2_devel branch (Unless the main branch has a security issue)
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have tested that my fix is effective or that my feature works

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@shitwolfymakes shitwolfymakes changed the title Add fix for #672 Ubuntu installer fixes Jan 26, 2023
@shitwolfymakes shitwolfymakes self-assigned this Jan 26, 2023
@shitwolfymakes shitwolfymakes added Fixed Issue has been resolved Ubuntu 20 labels Jan 26, 2023
@shitwolfymakes shitwolfymakes marked this pull request as ready for review January 26, 2023 02:13
@microtechno9000
Copy link
Collaborator

ran the installer, no issues encountered and arm installed

microtechno9000
microtechno9000 approved these changes Jan 26, 2023
View reviewed changes
Copy link
Collaborator

@microtechno9000 microtechno9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no issues with installer

@shitwolfymakes shitwolfymakes merged commit 538c9d9 into v2_devel Jan 26, 2023
@shitwolfymakes shitwolfymakes deleted the installer-fixes branch January 26, 2023 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@microtechno9000 microtechno9000 microtechno9000 approved these changes

Assignees

@shitwolfymakes shitwolfymakes

Labels
Fixed Issue has been resolved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shitwolfymakes @microtechno9000