Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More Script Fixes #680

Merged
merged 2 commits into from
Jan 22, 2023
Merged

More Script Fixes #680

merged 2 commits into from
Jan 22, 2023

Conversation

shitwolfymakes
Copy link
Member

Description

Fixes a couple of issues in the installation and setup scripts

Fixes #679
Fixes pycharm not being installed when the script runs in development mode

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

  • Ubuntu 18.04
  • Ubuntu 20.04
  • Debian 10
  • Debian 11
  • Docker
  • Other (Please state here)

Checklist:

  • I have submitted this PR against the v2_devel branch (Unless the main branch has a security issue)
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have tested that my fix is effective or that my feature works

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@shitwolfymakes shitwolfymakes marked this pull request as ready for review January 22, 2023 20:33
@shitwolfymakes shitwolfymakes self-assigned this Jan 22, 2023
@shitwolfymakes shitwolfymakes added Docker Issues with the docker version Fixed Issue has been resolved Ubuntu 20 labels Jan 22, 2023
@shitwolfymakes shitwolfymakes merged commit 3c16540 into v2_devel Jan 22, 2023
@shitwolfymakes shitwolfymakes deleted the script-fixes branch January 22, 2023 20:50
@shitwolfymakes shitwolfymakes mentioned this pull request Jan 22, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@microtechno9000 microtechno9000 microtechno9000 approved these changes

Assignees

@shitwolfymakes shitwolfymakes

Labels
Docker Issues with the docker version Fixed Issue has been resolved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shitwolfymakes @microtechno9000