Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(oidc): prompt parameter support #8080

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

james-d-elliott
Copy link
Member

This adds formal support for the prompt parameter.

Closes #2596

@authelia
Copy link

authelia bot commented Oct 21, 2024

Artifacts

These changes are published for testing on Buildkite, DockerHub and GitHub Container Registry.

Docker Container

  • docker pull authelia/authelia:feat-oidc-parameter-prompt
  • docker pull ghcr.io/authelia/authelia:feat-oidc-parameter-prompt

Copy link

netlify bot commented Oct 21, 2024

Deploy Preview for authelia-staging ready!

Name Link
🔨 Latest commit 9b40009
🔍 Latest deploy log https://app.netlify.com/sites/authelia-staging/deploys/676785c66054400008340a42
😎 Deploy Preview https://deploy-preview-8080--authelia-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@james-d-elliott james-d-elliott added this to the v4.39.0 milestone Oct 21, 2024
@james-d-elliott james-d-elliott added the area/openid-connect OpenID Connect 1.0 / OAuth 2.0 related features/bugs label Oct 21, 2024
@james-d-elliott james-d-elliott force-pushed the feat-oidc-parameter-prompt branch from 99e4639 to 4d2df02 Compare October 27, 2024 01:24
Copy link
Contributor

coderabbitai bot commented Oct 27, 2024

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Oct 27, 2024

Codecov Report

Attention: Patch coverage is 80.48916% with 351 lines in your changes missing coverage. Please review.

Project coverage is 74.82%. Comparing base (ad49811) to head (9b40009).

Files with missing lines Patch % Lines
...onsentPortal/OpenIDConnectConsentLoginFormView.tsx 0.00% 51 Missing and 10 partials ⚠️
internal/handlers/handler_firstfactor.go 62.85% 33 Missing and 6 partials ⚠️
internal/configuration/validator/authentication.go 6.89% 25 Missing and 2 partials ⚠️
web/src/views/ConsentPortal/ConsentPortal.tsx 0.00% 20 Missing and 2 partials ⚠️
internal/configuration/validator/util.go 0.00% 19 Missing ⚠️
internal/authentication/ldap_user_provider.go 90.44% 11 Missing and 6 partials ⚠️
web/src/services/ConsentOpenIDConnect.ts 0.00% 15 Missing and 1 partial ⚠️
...ndler_oidc_authorization_consent_pre_configured.go 0.00% 15 Missing ⚠️
internal/configuration/decode_hooks.go 76.36% 12 Missing and 1 partial ⚠️
internal/configuration/provider.go 80.30% 9 Missing and 4 partials ⚠️
... and 23 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8080      +/-   ##
==========================================
+ Coverage   73.79%   74.82%   +1.03%     
==========================================
  Files         349      359      +10     
  Lines       30294    31641    +1347     
  Branches      864      889      +25     
==========================================
+ Hits        22355    23676    +1321     
+ Misses       7056     7038      -18     
- Partials      883      927      +44     
Flag Coverage Δ
backend 76.02% <86.11%> (+1.35%) ⬆️
frontend 64.29% <7.03%> (-1.89%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/authentication/file_user_provider.go 98.15% <100.00%> (+0.22%) ⬆️
...rnal/authentication/file_user_provider_database.go 96.37% <100.00%> (+2.52%) ⬆️
...ernal/authentication/ldap_user_provider_startup.go 100.00% <100.00%> (ø)
internal/authentication/ldap_util.go 100.00% <100.00%> (ø)
internal/authentication/types.go 100.00% <100.00%> (ø)
internal/authorization/access_control_rule.go 100.00% <100.00%> (ø)
internal/authorization/types.go 100.00% <100.00%> (ø)
internal/authorization/util.go 98.48% <ø> (-0.43%) ⬇️
internal/configuration/schema/authentication.go 100.00% <100.00%> (ø)
internal/configuration/schema/types.go 74.78% <ø> (-0.92%) ⬇️
... and 54 more

... and 2 files with indirect coverage changes

@james-d-elliott james-d-elliott force-pushed the feat-oidc-parameter-prompt branch 2 times, most recently from 86ce39e to cec432b Compare October 28, 2024 03:21
@james-d-elliott james-d-elliott marked this pull request as draft October 28, 2024 03:27
@james-d-elliott james-d-elliott force-pushed the feat-oidc-parameter-prompt branch 15 times, most recently from 031a0d6 to 97b552b Compare November 7, 2024 09:28
@james-d-elliott james-d-elliott force-pushed the feat-oidc-parameter-prompt branch 3 times, most recently from aab3cb8 to 711a0af Compare November 16, 2024 03:33
@james-d-elliott james-d-elliott force-pushed the feat-oidc-parameter-prompt branch 2 times, most recently from 7823dcc to f547b1a Compare December 6, 2024 06:14
@james-d-elliott james-d-elliott force-pushed the feat-oidc-parameter-prompt branch 3 times, most recently from 2b7846e to 78afae3 Compare December 8, 2024 04:05
This adds reusable definitions into the mix for the configuration. This replaces the existing networks section for the access_control section and is automatically remapped for users.

Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
This facilitates adding additional attributes to the Authelia authentication backends as well as custom attributes based on the Common Expression Language. This will be utilized in the future to facilitate additional features.

Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
This adds a network criteria to the Authorization Policies for OpenID Connect 1.0 clients.

Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
This adds formal support for the prompt parameter.

Closes #2596
Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
@james-d-elliott james-d-elliott force-pushed the feat-oidc-parameter-prompt branch from 78afae3 to 9b40009 Compare December 22, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/openid-connect OpenID Connect 1.0 / OAuth 2.0 related features/bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OIDC prompt login
1 participant