Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(configuration): mail address decode hook func #2790

Merged
merged 5 commits into from
Jan 15, 2022

Conversation

james-d-elliott
Copy link
Member

This fixes an issue with the mail address decode hook func which previously would attempt to decode any struct type to a mail address.

This fixes an issue with the mail address decode hook func which previously would attempt to decode any struct type to a mail address.
@authelia
Copy link

authelia bot commented Jan 12, 2022

Artifacts

These changes are published for testing on Buildkite, DockerHub and GitHub Container Registry.

Docker Container

  • docker pull authelia/authelia:fix-mail-address-decode-hook
  • docker pull ghcr.io/authelia/authelia:fix-mail-address-decode-hook

Copy link
Member

@clems4ever clems4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a unit test?

@james-d-elliott
Copy link
Member Author

I actually think there is one, let me double check. It's part of configurati

Can we add a unit test?

@clems4ever done!

@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #2790 (f82587b) into master (73b7900) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2790      +/-   ##
==========================================
+ Coverage   68.36%   68.41%   +0.04%     
==========================================
  Files         215      215              
  Lines       11207    11207              
  Branches      436      436              
==========================================
+ Hits         7662     7667       +5     
+ Misses       3084     3081       -3     
+ Partials      461      459       -2     
Flag Coverage Δ
backend 67.58% <100.00%> (+0.03%) ⬆️
frontend 70.33% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/configuration/decode_hooks.go 100.00% <100.00%> (ø)
internal/ntp/util.go 88.46% <0.00%> (+11.53%) ⬆️
web/src/services/SignOut.ts 100.00% <0.00%> (+16.66%) ⬆️

@james-d-elliott james-d-elliott merged commit fe4bfc1 into master Jan 15, 2022
@james-d-elliott james-d-elliott deleted the fix-mail-address-decode-hook branch January 15, 2022 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants