-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(configuration): mail address decode hook func #2790
Conversation
This fixes an issue with the mail address decode hook func which previously would attempt to decode any struct type to a mail address.
ArtifactsThese changes are published for testing on Buildkite, DockerHub and GitHub Container Registry. Docker Container
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a unit test?
I actually think there is one, let me double check. It's part of configurati
@clems4ever done! |
Codecov Report
@@ Coverage Diff @@
## master #2790 +/- ##
==========================================
+ Coverage 68.36% 68.41% +0.04%
==========================================
Files 215 215
Lines 11207 11207
Branches 436 436
==========================================
+ Hits 7662 7667 +5
+ Misses 3084 3081 -3
+ Partials 461 459 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This fixes an issue with the mail address decode hook func which previously would attempt to decode any struct type to a mail address.