-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: install missing dependencies #2
Conversation
@agfcrespi it currently fails under MacOS with:
I guess support for MacOS is simply not available at the moment? |
@hagenw Only Linux and Windows for the moment: https://gitlab.audeering.com/tools/audresamplelib/-/blob/master/.gitlab-ci.yml . But I guess we can easily support macOS as well (please open an issue there if needed). I remember @aud-ktw had tried it out once, and I think it was working fine. |
Unfortunately, the test for Windows also fails:
Is there something I have to adjust? |
Mmm, I am not sure what the problem is here. Admittedly, we have never really tested on Windows either (even though we are building the DLL of the native library and providing it to this project). Maybe it would be more elegant and less error-prone to create a Conan recipe and consume the binaries via Conan directly (rather than committing the binaries to the repository), but we have not tried this path yet and we don't have experience with it. Is there an urgent need to support Windows and macOs? |
Yes, as we need this in |
If I compare https://github.com/audeering/audresample/tree/master/audresample/core/bin with https://github.com/audeering/opensmile-python/tree/master/opensmile/core/bin then it seems to me that for |
Of course we still provide different libraries and select them here: |
So maybe as a start I will disable tests under Windows as well and open an issue for that. |
I think both approaches are valid. |
Install
libsndfile1
under Ubuntu, alsosox
under Ubuntu (not sure yet if needed), Windows and MacOS.