This repository has been archived by the owner on Aug 28, 2021. It is now read-only.
NGQL: Handle null better in input data #3272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Struct fields are not allowed to be null or missing. Lists/Sets may not contain null.
kalman
approved these changes
Mar 15, 2017
| test(m2, `{"data":null,"errors":[{"message":"Variable \"$ks\" got invalid value [{}].\nIn element #1: In field \"n\": Expected \"String!\", found null.","locations":[{"line":1,"column":12}]}]}`, | ||
| q, | ||
| map[string]interface{}{ | ||
| "ks": []interface{}{ |
There was a problem hiding this comment.
I think you can leave out this []interface{}, Go can figure out the type?
There was a problem hiding this comment.
There are cases where the type name is not needed. This case is needed though.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Struct fields are not allowed to be null or missing.
Lists/Sets may not contain null.