Skip to content
This repository has been archived by the owner on Aug 28, 2021. It is now read-only.

Better naming for graphql fields #3153

Merged
1 commit merged into from Feb 7, 2017
Merged

Better naming for graphql fields #3153

1 commit merged into from Feb 7, 2017

Conversation

ghost
Copy link

@ghost ghost commented Feb 7, 2017

TBR @arv Sorry, was going to this in the last patch, but forgot. Just name changes. I think this is better than a sea of "value".

@ghost ghost merged commit 00d1699 into attic-labs:master Feb 7, 2017
@ghost ghost deleted the betterGQLFieldNames branch February 7, 2017 03:46
Copy link
Contributor

@arv arv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -19,23 +19,23 @@ List:
```
type FooList {
size: Float!
values: [Foo!]!
elements: [Foo!]!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant