Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BigIntPowerTests
Following test fails at
BigUInt.power
->precondition(!self.isZero)
:BigIntStringInitTests
A lot of those tests depend on how you want to parse, so some of them are not bugs.
Empty string
For example this would
throw
in Violet:Minus 0
This produces
-0
(should be just0
):Octal
Some octal tests fail, but this may be on Violet.
I would love for someone to validate, because I am obviously biased.
Underscores
This passes:
This fails to parse (
nil
):The only difference is that we added some
_
inside.BigIntPropertyTests
Zero
This fails:
I think that inside the
Swift.Int
rangeBigInt
should return the same values asSwift.Int
. Although this is debatable.There is a test that compares
Int.words
vsBigInt.words
for the same values (it also fails)Bit width
I think that inside the
Swift.Int
rangeBigInt
should return the same values asSwift.Int
. Although this is debatable.My comments and tests result are inline:
In general, I think that for negative powers of 2 attaswift returns
+1
.