This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Only show project load times when a project is deserialized #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 4, 2017 19:33
Also, reorganize display order: * Shell * Window * Window state * Project * Workspace
This is just project load time + workspace load time, and is 0 when no project is loaded.
|
For reference, the only code that is executed that is captured by window state load time and not project/workspace load time is the following: The time those lines take is extremely inconsequential. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
This prevents project and workspace load times from showing up as
undefinedms. In addition, I have removed the window state load time as it was just the project load time and the workspace load time added together (and 0 when there was no project to load). Finally, the display order has been changed to better follow the logical load order:Alternate Designs
None.
Benefits
More logical display order and hiding of project + workspace times when there is no previous state.
Possible Drawbacks
None.
Applicable Issues
Fixes #24
Fixes #19