Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Cleanup #28

Merged
merged 3 commits into from
Nov 4, 2017
Merged

Cleanup #28

merged 3 commits into from
Nov 4, 2017

Conversation

winstliu
Copy link
Contributor

@winstliu winstliu commented Nov 4, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

  • Use atom.packages.hasActivatedInitialPackages() (and the relevant hook) to determine when to populate the Timecop view
    • Show Loading… before packages have finished activating
    • Prevents Timecop from improperly showing only a few packages activated due to the process.nextTick call
  • Remove optional Workspace methods in TimecopView that were just stubs

Alternate Designs

I noticed that there was also an atom.packages.hasLoadedInitialPackages. I'm going to experiment with that to see if we can use that to split up the view loading.

Benefits

Code savings and more accurate Timecop view

Possible Drawbacks

None.

Applicable Issues

None.

@winstliu
Copy link
Contributor Author

winstliu commented Nov 4, 2017

timecop-loading

@winstliu winstliu merged commit 57b44ef into master Nov 4, 2017
@winstliu winstliu deleted the wl-cleanup branch November 4, 2017 18:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant