This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Fix mistakenly shown docks drop indicator on Electron >= 1.4 #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
|
Thanks! |
60 tasks
59 tasks
8 tasks
7 tasks
76 tasks
58 tasks
64 tasks
64 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a regression that we were observing on newer Electron versions due to reasons similar to the ones described in #426. In particular, on Electron >= 1.4 we were showing a drop indicator even for dock locations that were unsupported by the dragged item.
Analogously to the aforementioned pull request, in this one we are replacing usages of
dataTransfer.getDatain thedragoverhandler with a scan of the keys present inside thedataTransferobject./cc: @nathansobo @maxbrunsfeld