This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Make the package work with tree-sitter #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxbrunsfeld
force-pushed
the
mb-tree-sitter-compat
branch
from
c719fea to
8838e30
Compare
12 tasks
maxbrunsfeld
force-pushed
the
mb-tree-sitter-compat
branch
from
8838e30 to
6750fe8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Previously, this package contained a lot of logic that is specific to TextMate scopes: things like finding tag names and attribute names. When we enable Tree-sitter by default, this logic won't work.
Solution
I've added a parallel implementation of the autocomplete provider for Tree-sitter. It shares the logic for finding completions, but has different logic for finding tokens like tag names and attribute tames.