Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Update to Electron v0.33.x #8779

Merged
merged 14 commits into from
Oct 16, 2015
Merged

Update to Electron v0.33.x #8779

merged 14 commits into from
Oct 16, 2015

Conversation

zcbenz
Copy link
Contributor

@zcbenz zcbenz commented Sep 14, 2015

Node modules to update:

  • runas
  • pathwatcher
  • nslog
  • oniguruma
  • git-utils
  • spellchecker
  • scrollbar-style
  • keyboard-layout
  • atom-keymap
  • first-mate
  • scandal
  • text-buffer
  • apm
  • highlights
  • ctags

Atom packages to update:

  • bracket-matcher
  • link
  • markdown-preview
  • symbols-view
  • tree-view
  • spell-check

Fixes #8508
Fixes #7061
Fixes #3593

@zcbenz zcbenz mentioned this pull request Sep 14, 2015
Closed
@gisenberg
Copy link

I tried to check out the CI failures for git-utils, but Janky is reporting that the repository doesn't exist. Is there a way for me to see what went wrong? I did a local build from this branch, which yielded a bunch of gateway/network connectivity errors that didn't repro on master.

Also, I have a PR to update scrollbar-style to nan 2.0 over here: atom/scrollbar-style#9

@mnquintana
Copy link
Contributor

I tried to check out the CI failures for git-utils, but Janky is reporting that the repository doesn't exist.

You'll want to take a look at the Travis build instead of Janky: https://travis-ci.org/atom/atom/builds/80163437

@zcbenz zcbenz mentioned this pull request Sep 21, 2015
Closed
This was referenced Sep 21, 2015
Closed
Closed
@zcbenz zcbenz changed the title Update to Electron v0.32.x Update to Electron v0.33.x Sep 22, 2015
@zcbenz
Copy link
Contributor Author

zcbenz commented Sep 22, 2015

This branch now compiles on all platforms, though we still have many failing specs.

@as-cii
Copy link
Contributor

as-cii commented Sep 22, 2015

While having a look at the failing specs, I have noticed that this warning messages was logged out:

[51599:0922/092254:INFO:CONSOLE(0)] "::shadow pseudo-element is deprecated. See https://www.chromestatus.com/features/6750456638341120 for more details.", source:  (0)

This could potentially break third party themes in future versions of Chrome so it's something to keep in mind the next time we upgrade electron, although it doesn't block this specific PR.

P.s. awesome work on this, @zcbenz! ✨

@zcbenz zcbenz mentioned this pull request Sep 23, 2015
Merged
This was referenced Sep 24, 2015
Merged
Merged
@as-cii
Copy link
Contributor

as-cii commented Sep 25, 2015

I think that code-wise this is good to go! ✨ I'll change the label to needs-review and test this out for a couple of days.

@zcbenz: do you think there's anything else holding this up?

@nathansobo
Copy link
Contributor

I'm noticing that using cmd-o to open a file/directory in a new window isn't working for me on OS X. It displays the dialog, but never opens a new window with what I select.

@nathansobo
Copy link
Contributor

Also having problems opening an additional window via the atom command from the command line.

@nathansobo
Copy link
Contributor

Fixed the opening issues... Seeing some issues positioning overlay decorations wrong... not sure it's this branch but I want to investigate.

@nathansobo
Copy link
Contributor

Ugh, specs are hanging on CI after my latest commit. Not sure what's going on there.

Also, I'm noticing that overlay decorations are positioned incorrectly to the right side of longer lines upon first loading a window, but not after reloading it.

@thomasjo
Copy link
Contributor

@nathansobo CI failures started after @50Wliu bumped Electron to v0.33.3, so there's likely something broke in either v0.33.2 or v0.33.3. I haven't got time to investigate further right now though, sorry.

@joshaber joshaber mentioned this pull request Sep 30, 2015
Closed
@kevinsawicki kevinsawicki mentioned this pull request Sep 30, 2015
Closed
@zcbenz
Copy link
Contributor Author

zcbenz commented Oct 1, 2015

I believe the failing specs are caused by electron/electron#2935.

@thomasjo
Copy link
Contributor

thomasjo commented Oct 2, 2015

@zcbenz Specs are passing now! ✨

@thomasjo thomasjo mentioned this pull request Oct 4, 2015
Closed
@thomasjo
Copy link
Contributor

thomasjo commented Oct 4, 2015

This seems good to go. Will test a rebased build of this today to hunt for possibly undetected regressions.

@winstliu winstliu mentioned this pull request Oct 4, 2015
Closed
zcbenz and others added 12 commits October 16, 2015 11:08
@zcbenz
⬆️ electron@0.33.1
9354b86
@zcbenz
registerProtocol has been deprecated
70fc6dd
@zcbenz
Disable pinch-to-zoom, fixes #8850
a5c9fce
@as-cii
Adhere to CoffeeScript.compile contract
224f2e9 
...which always returns the source map as a string. This is needed because
`Buffer` now requires to be initialized with either a number, a buffer, an array
or a string.
@as-cii
Change invalid.js fixture for babel transpilation
23d5dc8 
The previous file was considered invalid on the earlier version of electron, but
it now compiles correctly because of the updated ES6 support.
⬆️ electron@0.33.3
0f7c852
Use WebContents.prototype.isLoading instead of defunct .loaded
5f2b5a1 
Fixes cmd-o interaction.
@thomasjo
⬆️ electron@0.33.4
f0b7356
@thomasjo
⬆️ electron@0.33.5
bbf25e7
⬆️ electron@0.33.6
1bfcea3
Fix spec failures due to slight changes in DOM positioning
6616078
Add disablePinchToZoom to ApplicationDelegate
badba28
@nathansobo
Copy link
Contributor

The only thing failing was docs generation, which is fixed on master. Merging this now.

nathansobo pushed a commit that referenced this pull request Oct 16, 2015
Merge pull request #8779 from atom/cz-electron-32
26a5b26 
Update to Electron v0.33.x
@nathansobo nathansobo merged commit 26a5b26 into master Oct 16, 2015
@nathansobo nathansobo deleted the cz-electron-32 branch October 16, 2015 21:59
@winstliu winstliu mentioned this pull request Oct 16, 2015
Merged
@thomasjo
Copy link
Contributor

Nice!

@zcbenz zcbenz mentioned this pull request Dec 21, 2015
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zcbenz @gisenberg @mnquintana @as-cii @nathansobo @thomasjo