This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Add settings to enable and disable softTabs autodetection #8186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Behaviour of tabType functions is discussed on issue atom#3719. Also, introduce userTabTypeOverride variable which hold temporary user preference on current editor.
|
Thanks for contributing! This seems to break a lot of specs – you'll need to fix those before this can be considered for merging. |
|
Ok, I don't aware of that tailing spec test and neither I have test it myself. |
My first assumption is toggleSoftTabs() cause all TextEditor instance have the same value in @softTabs. It is wrong. Now it's clear that scopeDescriptor makes change only affect individual TextEditor.
Abdillah
changed the title
Originally, it always autodetects. Now, it's only autodetect softTabs when no @softTabs supplied on TextEditor construction or `editor.tabType` has value 'auto'.
Originally, any value supplied will just be a fallback. Now, this value is regarded as first priority. If this value not specified, then autodetection will occurs. Specification changes included.
|
Checkpoint One |
Merged
|
I've created a new PR to add this setting at #8356. This PR is trying to do too much (new API methods, setting config in the editor), and it is lacking specs. I have used a couple commits from this PR in the new one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solved the issue (partly), discussed on #3719.
I create new config item to specify tabType used by default. But, it clearly conflicting with softTabs config item. I didn't remove it, even I think it's safe to be removed, is it?