This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Use custom element on pane-element #22751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadick254
force-pushed
the
use-custom-element-on-pane-element
branch
from
4e94aac to
53d4948
Compare
sadick254
force-pushed
the
use-custom-element-on-pane-element
branch
from
53d4948 to
bdf94a6
Compare
sadick254
force-pushed
the
use-custom-element-on-pane-element
branch
6 times, most recently
from
c5a06f7 to
4f3e0e1
Compare
document.registerElement is being deprecated which will make upgrading to later versions of electron imposible
The tests were failing due to nodes not being found on the DOM.
sadick254
force-pushed
the
use-custom-element-on-pane-element
branch
from
4f3e0e1 to
7074840
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
document.registerElementis being deprecated which will make upgradingto later versions of electron impossible