-
Notifications
You must be signed in to change notification settings - Fork 17.4k
Make sure path is not undefined (#20871) #22685
Conversation
@bennyborn Unforunately you can't use the nullish coalescing operator (because stuff is outdated) Also add spaces around the operators to pass the linter check, which counts as a test: |
Co-authored-by: steven nguyen <nguyeste008@students.garlandisd.net>
@icecream17 Thanks. Haven't looked into the checks since this morning. |
apply changes suggested by linter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please have some specs on this PR?
I'm not quite sure what you mean by that. What do you need? |
spec = test |
That makes two of us. I could try if I had any clue how the original problem occured in the first place but as stated in my first post I can only provide a fix, not an explanation :\ |
A test that sets up Edit: Seems kind of hard to test that level of internal detail in the spec file, because that level of hidden implementation detail stuff isn't exported from |
Identify the Bug
This fixes a bug where upating the rights (CHMOD) of files mounted on a SMB share causes the path watcher to create an invalid path (see #20871)
Description of the Change
While I do not understand the exact origins how this bug comes together, I still managed to provide a very obvious fix for something that should be a string rather than
undefined
.Alternate Designs
none
Possible Drawbacks
none
Verification Process
Working with files from a SMB share (Windows host) on a daily basis it is as simple as having open a SMB mounted directory and updating the rights of the folder via
chmod -R 775
.Release Notes
Fixed an error that occurs when working with files from a SMB share