Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Update the macOS Azure CI image to macos-10.15 #21318

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

Aerijo
Copy link
Contributor

@Aerijo Aerijo commented Sep 16, 2020

Requirements for Adding, Changing, or Removing a Feature

Description of the Change

Updates the macOS Azure CI image from macos-10.14 to macos-10.15. This

  • Makes sure we are testing on the latest possible macOS image
  • Updates npm from 3.10.10 to 6.14.6, most likely removing the need to upgrade it separately (see Don't reinstall npm in CI #21317)

Alternate Designs

NA

Possible Drawbacks

Could fail to detect changes that are incompatible with 10.14. But then, by the same logic, the current setup doesn't detect incompatibilities with 10.15, which is more recent and therefore more important IMO.

Verification Process

CI passes

Release Notes

NA

@Aerijo
Copy link
Contributor Author

Aerijo commented Sep 16, 2020

Located all macOS builds by searching for macos-10.14 in scripts.

@Aerijo
Copy link
Contributor Author

Aerijo commented Sep 16, 2020

This appears to cancel the effects of the Update npm job (source)

Node:	v12.16.3
Npm:	v6.14.6
Python:	v2.7.17

It should not be a concern if the tests pass though, and the Linux job already doesn't use the intended npm version anyway.

Copy link
Contributor

@aminya aminya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a good idea.

@aminya
Copy link
Contributor

aminya commented Sep 16, 2020

This appears to cancel the effects of the Update npm job (source)

Node:	v12.16.3
Npm:	v6.14.6
Python:	v2.7.17

It should not be a concern if the tests pass though, and the Linux job already doesn't use the intended npm version anyway.

That's probably because npm is installed somewhere else in the new Mac

$env:NPM_BIN_PATH="/usr/local/bin/npm"

script/vsts/platforms/linux.yml Outdated Show resolved Hide resolved
@sadick254 sadick254 merged commit 0a169b5 into atom:master Nov 18, 2020
DeeDeeG added a commit to DeeDeeG/atom that referenced this pull request Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants