This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Fix: Added capturing to keydown events when hiding tooltips #17958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
daviwil
approved these changes
Sep 6, 2018
There was a problem hiding this comment.
Restarted VSTS build failed for an unrelated reason, I think this PR is good. Thanks a lot @cacheflow!
cacheflow
deleted the
add-capturing-to-keydown-events-when-hiding-tooltips
branch
This was referenced Sep 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Fix #17957 by ensuring capturing occurs and the event is bubbled up to the window.
Alternate Designs
None.
Benefits
It fixes an issue where users may want to see the workspace they're typing in, but a tooltip is hiding it.
Possible Drawbacks
It adds an additional event listener for each tooltip.
Verification Process
I modified the existing tooltip-manager spec to include a new test for this feature, ran the test suite, and also manually tested it by reproducing the steps listed in #17957.
Before fix
After fix
Applicable Issues
#17957