This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Fix "check for update" crash #1693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 4, 2014 12:26
Fixes #1689, gets around the crashing bug when displaying a dialog when update is found.
probablycorey
pushed a commit
that referenced
this pull request
Mar 4, 2014
Fix "check for update" crash
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Click "Check for update" was causing Atom to crash when the dialog appeared. I wasn't able to fix the dialog problem because it seems to be a deeper atom-shell issue. Instead I replace the "Check for Update" menu item with a "Downloading Update" menu item.