This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Fix PaneContainer::onDidStopChangingActivePaneItem()
#14375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do I need to avoid |
|
Ah, yeah, if one of these is created during the snapshotting phase, then globals like |
matthewwithanm
force-pushed
the
fb-mdt-ondidstopchangingactivepaneitem
branch
2 times, most recently
from
28c74ee to
14c7c67
Compare
|
@damieng do you think the timeouts on 32-bit windows are spurious failures? |
|
@damieng Nevermind. The build failures are my fault. |
nathansobo
force-pushed
the
fb-mdt-ondidstopchangingactivepaneitem
branch
from
14c7c67 to
3929687
Compare
|
Rebased. I think our build should be green now. |
We weren't ever dispatching this event! Oops XD
matthewwithanm
force-pushed
the
fb-mdt-ondidstopchangingactivepaneitem
branch
from
3929687 to
26d9579
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We we're allowing subscription to this event, but never actually triggering it 😨
This is mostly copypasta from the implementation in workspace. lmk if you'd prefer something different.
I also added a test for
onDidChangeActivePane()which I can separate into another commit if you want or drop entirely. (I was attempting to repro the other part of #14369 but it seems to work for me.)cc @BinaryMuse @nathansobo