Improve Table to/from pandas #8247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8247 +/- ##
==========================================
+ Coverage 86.91% 86.92% +0.01%
==========================================
Files 383 384 +1
Lines 57889 57995 +106
Branches 1056 1060 +4
==========================================
+ Hits 50313 50412 +99
- Misses 6962 6968 +6
- Partials 614 615 +1
Continue to review full report at Codecov.
|
|
Rebased and passing all tests now. |
astrofrog
reviewed
Dec 12, 2018
There was a problem hiding this comment.
@taldcroft - This looks good to me, but just one question - is YAML really needed since we aren't actually saving the YAML metadata, but just using the serialization machinery?
|
@astrofrog - good catch! I was just blindly copying precedent in HDF5 or ECSV, but in fact there is no YAML dependency. See 821946f. |
astrofrog
approved these changes
Dec 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the support for converting Table to and from pandas:
TimeandTimeDeltavia numpydatetime64andtimedelta64.to_pandas().To do:
from_pandas().See also #8246 that came out of this work.
Closes #5081