Use `ArcStr` for marker values #10453

charliermarsh · 2025-01-10T01:07:46Z

N.B. After fixing #10430, ArcStr became the fastest implementation (and the gains were significantly reduced, down to 1-2%). See: #10453 (comment).

Summary

I tried out a variety of small string crates, but Arc<str> outperformed them, giving a ~10% speed-up:

❯ hyperfine "../arcstr lock" "../flexstr lock" "uv lock" "../arc lock" "../compact_str lock" --prepare "rm -f uv.lock" --min-runs 50 --warmup 20
Benchmark 1: ../arcstr lock
  Time (mean ± σ):     304.6 ms ±   2.3 ms    [User: 302.9 ms, System: 117.8 ms]
  Range (min … max):   299.0 ms … 311.3 ms    50 runs

Benchmark 2: ../flexstr lock
  Time (mean ± σ):     319.2 ms ±   1.7 ms    [User: 317.7 ms, System: 118.2 ms]
  Range (min … max):   316.8 ms … 323.3 ms    50 runs

Benchmark 3: uv lock
  Time (mean ± σ):     330.6 ms ±   1.5 ms    [User: 328.1 ms, System: 139.3 ms]
  Range (min … max):   326.6 ms … 334.2 ms    50 runs

Benchmark 4: ../arc lock
  Time (mean ± σ):     303.0 ms ±   1.2 ms    [User: 301.6 ms, System: 118.4 ms]
  Range (min … max):   300.3 ms … 305.3 ms    50 runs

Benchmark 5: ../compact_str lock
  Time (mean ± σ):     320.4 ms ±   2.0 ms    [User: 318.7 ms, System: 120.8 ms]
  Range (min … max):   317.3 ms … 326.7 ms    50 runs

Summary
  ../arc lock ran
    1.01 ± 0.01 times faster than ../arcstr lock
    1.05 ± 0.01 times faster than ../flexstr lock
    1.06 ± 0.01 times faster than ../compact_str lock
    1.09 ± 0.01 times faster than uv lock

zanieb

Nice and simple

konstin · 2025-01-10T10:08:49Z

Which test case did you use?

BurntSushi

Very interesting. I'm a little surprised that Arc<str> wins here (although it seems virtually tied with arcstr), especially given that these strings tend to be extremely small.

charliermarsh · 2025-01-10T13:10:12Z

I used the test case from #10430.

@BurntSushi — Which would you have expected to win here? Do you think I did anything wrong?

BurntSushi · 2025-01-10T14:08:07Z

@BurntSushi — Which would you have expected to win here? Do you think I did anything wrong?

No not all. Basically, if most of our strings are very short, I'd expect this to trigger the "fast path" inside the small string data types where creation doesn't need a heap alloc and access doesn't need an indirection. Hazarding a guess, this might also be related to the size of a string itself. An ArcStr is only 8 bytes, an Arc<str> is 16 bytes but both compact_str::CompactString and flexstr::SharedStr are 24 bytes. So maybe perf here is more related CPU cache efficiency? Very hard to say without a deep dive here. But I approve of your methods here for an easy win.

Maybe there are lots of cases where the strings aren't small though, and this is triggering the slower path in the small string types.

charliermarsh · 2025-01-10T14:15:23Z

I could also try re-benching it once #10430 is addressed? It's possible that the cloning here is dominant and that's somehow faster with Arc.

charliermarsh · 2025-01-10T17:46:01Z

Ok, now that #10430 is addressed, I re-ran this. It looks like arcstr is the best-performing, but the gains are much smaller (1-2%).

For the case from #10430:

❯ hyperfine "../arcstr lock" "../flex_str lock" "../uv lock" "../arc lock" "../compact_str lock" --prepare "rm -f uv.lock" --min-runs 50 --warmup 20
Benchmark 1: ../arcstr lock
  Time (mean ± σ):     218.1 ms ±   2.6 ms    [User: 217.3 ms, System: 113.5 ms]
  Range (min … max):   214.8 ms … 230.6 ms    50 runs

  Warning: Statistical outliers were detected. Consider re-running this benchmark on a quiet system without any interferences from other programs.

Benchmark 2: ../flex_str lock
  Time (mean ± σ):     220.8 ms ±   1.9 ms    [User: 220.1 ms, System: 112.2 ms]
  Range (min … max):   218.8 ms … 231.6 ms    50 runs

  Warning: Statistical outliers were detected. Consider re-running this benchmark on a quiet system without any interferences from other programs.

Benchmark 3: ../uv lock
  Time (mean ± σ):     221.0 ms ±   1.1 ms    [User: 220.3 ms, System: 112.4 ms]
  Range (min … max):   218.8 ms … 224.2 ms    50 runs

Benchmark 4: ../arc lock
  Time (mean ± σ):     218.7 ms ±   1.0 ms    [User: 218.1 ms, System: 112.2 ms]
  Range (min … max):   216.9 ms … 221.3 ms    50 runs

Benchmark 5: ../compact_str lock
  Time (mean ± σ):     219.3 ms ±   1.2 ms    [User: 219.3 ms, System: 112.2 ms]
  Range (min … max):   216.9 ms … 223.7 ms    50 runs

Summary
  ../arcstr lock ran
    1.00 ± 0.01 times faster than ../arc lock
    1.01 ± 0.01 times faster than ../compact_str lock
    1.01 ± 0.01 times faster than ../flex_str lock
    1.01 ± 0.01 times faster than ../uv lock

For airflow.in:

❯ hyperfine "../arcstr pip compile --universal ../scripts/requirements/airflow.in" "../flex_str pip compile --universal ../scripts/requirements/airflow.in" "../uv pip compile --universal ../scripts/requirements/airflow.in" "../arc pip compile --universal ../scripts/requirements/airflow.in" "../compact_str pip compile --universal ../scripts/requirements/airflow.in" --min-runs 50 --warmup 20
Benchmark 1: ../arcstr pip compile --universal ../scripts/requirements/airflow.in
  Time (mean ± σ):     132.2 ms ±   2.5 ms    [User: 136.7 ms, System: 226.6 ms]
  Range (min … max):   126.6 ms … 141.2 ms    50 runs

Benchmark 2: ../flex_str pip compile --universal ../scripts/requirements/airflow.in
  Time (mean ± σ):     134.3 ms ±   2.8 ms    [User: 138.4 ms, System: 240.2 ms]
  Range (min … max):   130.2 ms … 146.0 ms    50 runs

Benchmark 3: ../uv pip compile --universal ../scripts/requirements/airflow.in
  Time (mean ± σ):     134.7 ms ±   4.3 ms    [User: 138.9 ms, System: 240.3 ms]
  Range (min … max):   129.8 ms … 153.8 ms    50 runs

Benchmark 4: ../arc pip compile --universal ../scripts/requirements/airflow.in
  Time (mean ± σ):     133.8 ms ±   3.4 ms    [User: 138.3 ms, System: 233.6 ms]
  Range (min … max):   129.1 ms … 150.3 ms    50 runs

Benchmark 5: ../compact_str pip compile --universal ../scripts/requirements/airflow.in
  Time (mean ± σ):     133.8 ms ±   2.4 ms    [User: 139.0 ms, System: 231.1 ms]
  Range (min … max):   128.5 ms … 138.8 ms    50 runs

Summary
  ../arcstr pip compile --universal ../scripts/requirements/airflow.in ran
    1.01 ± 0.03 times faster than ../arc pip compile --universal ../scripts/requirements/airflow.in
    1.01 ± 0.03 times faster than ../compact_str pip compile --universal ../scripts/requirements/airflow.in
    1.02 ± 0.03 times faster than ../flex_str pip compile --universal ../scripts/requirements/airflow.in
    1.02 ± 0.04 times faster than ../uv pip compile --universal ../scripts/requirements/airflow.in

Any objections to using arcstr? We could also leave it as-is, though arcstr is both faster and uses less memory.

BurntSushi · 2025-01-10T18:27:17Z

I'd hedge toward arcstr given its smaller size. But totally fine keeping status quo given the updated measurements.

charliermarsh · 2025-01-10T18:27:32Z

Sounds good, I'll ship that.

This reverts commit a5da1d8.

This reverts commit f61326b.

This reverts commit 6bb5cc8.

This reverts commit 7c81ecb.

This reverts commit 2d51b31.

This reverts commit 787382e.

This reverts commit 7c11b59.

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.5.15` -> `0.5.22` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>astral-sh/uv (astral-sh/uv)</summary> ### [`v0.5.22`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0522) [Compare Source](astral-sh/uv@0.5.21...0.5.22) ##### Enhancements - Include version and contact information in GitHub User Agent ([#10785](astral-sh/uv#10785)) ##### Performance - Add fast-path for recursive extras in dynamic validation ([#10823](astral-sh/uv#10823)) - Fetch `pyproject.toml` from GitHub API ([#10765](astral-sh/uv#10765)) - Remove allocation in Git SHA truncation ([#10801](astral-sh/uv#10801)) - Skip GitHub fast path when full commit is already known ([#10800](astral-sh/uv#10800)) ##### Bug fixes - Add fallback to build backend when `Requires-Dist` mismatches ([#10797](astral-sh/uv#10797)) - Avoid deserialization error for paths above the root ([#10789](astral-sh/uv#10789)) - Avoid respecting preferences from other indexes ([#10782](astral-sh/uv#10782)) - Disable the distutils setuptools shim during interpreter query ([#10819](astral-sh/uv#10819)) - Omit variant when detecting compatible Python installs ([#10722](astral-sh/uv#10722)) - Remove TOCTOU errors in Git clone ([#10758](astral-sh/uv#10758)) - Validate metadata under GitHub fast path ([#10796](astral-sh/uv#10796)) - Include conflict markers in fork markers ([#10818](astral-sh/uv#10818)) ##### Error messages - Add tag incompatibility hints to sync failures ([#10739](astral-sh/uv#10739)) - Improve log when distutils is missing ([#10713](astral-sh/uv#10713)) - Show non-critical Python discovery errors if no other interpreter is found ([#10716](astral-sh/uv#10716)) - Use colors for lock errors ([#10736](astral-sh/uv#10736)) ##### Documentation - Add testing instructions to the AWS Lambda guide ([#10805](astral-sh/uv#10805)) ### [`v0.5.21`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0521) [Compare Source](astral-sh/uv@0.5.20...0.5.21) ##### Enhancements - Avoid building dynamic versions when validating lockfile ([#10703](astral-sh/uv#10703)) ##### Configuration - Add `UV_VENV_SEED` environment variable ([#10715](astral-sh/uv#10715)) ##### Performance - Store unsupported tags in wheel filename ([#10665](astral-sh/uv#10665)) ##### Bug fixes - Avoid attempting to patch macOS dylib for non-macOS installs ([#10721](astral-sh/uv#10721)) - Avoid narrowing `requires-python` marker with disjunctions ([#10704](astral-sh/uv#10704)) - Respect environment variable credentials for indexes outside root ([#10688](astral-sh/uv#10688)) - Respect preferences for explicit index dependencies from `requirements.txt` ([#10690](astral-sh/uv#10690)) - Sort preferences by environment, then index ([#10700](astral-sh/uv#10700)) - Ignore permission errors when looking for user-level configuration file ([#10697](astral-sh/uv#10697)) ##### Documentation - Add `SyntaxWarning` compatibility note to bytecode compilation docs ([#10701](astral-sh/uv#10701)) - Add `MACOSX_DEPLOYMENT_TARGET` to the `--python-platform` documentation ([#10698](astral-sh/uv#10698)) ### [`v0.5.20`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0520) [Compare Source](astral-sh/uv@0.5.19...0.5.20) ##### Bug fixes - Avoid failing when deserializing unknown tags ([#10655](astral-sh/uv#10655)) ### [`v0.5.19`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0519) [Compare Source](astral-sh/uv@0.5.18...0.5.19) ##### Enhancements - Filter wheels from lockfile based on architecture ([#10584](astral-sh/uv#10584)) - Omit dynamic versions from the lockfile ([#10622](astral-sh/uv#10622)) - Add support for `pip freeze --path` ([#10488](astral-sh/uv#10488)) - Reduce verbosity of inline-metadata message when using `uv run <script.py>` ([#10588](astral-sh/uv#10588)) - Add opt-in Git LFS support ([#10335](astral-sh/uv#10335)) - Recommend `--native-tls` on SSL errors ([#10605](astral-sh/uv#10605)) - Show expected and available ABI tags in resolver errors ([#10527](astral-sh/uv#10527)) - Show target Python version in error messages ([#10582](astral-sh/uv#10582)) - Add `--output-format=json` support to `uv python list` ([#10596](astral-sh/uv#10596)) ##### Python The managed Python distributions have been updated, including: - Python 3.14 support on Windows - Python 3.14.0a4 support - 64-bit RISC-V Linux support - Bundled `libedit` updated from [`2021091`](https://github.com/astral-sh/uv/commit/20210910)-3.1 -> [`2024080`](https://github.com/astral-sh/uv/commit/20240808)-3.1 - Bundled `tcl/tk` updated from 8.6.12 -> 8.6.14 (for all Python versions on Unix, only for Python 3.14 on Windows) See the [`python-build-standalone` release notes](https://github.com/astral-sh/python-build-standalone/releases/tag/20250115) for more details. ##### Performance - Avoid allocating when stripping source distribution extension ([#10625](astral-sh/uv#10625)) - Reduce `WheelFilename` to 48 bytes ([#10583](astral-sh/uv#10583)) - Reduce distribution size to 200 bytes ([#10601](astral-sh/uv#10601)) - Remove `import re` from entrypoint wrapper scripts ([#10627](astral-sh/uv#10627)) - Shrink size of platform tag enum ([#10546](astral-sh/uv#10546)) - Use `ArcStr` in verbatim URL ([#10600](astral-sh/uv#10600)) - Use `memchr` for wheel parsing ([#10620](astral-sh/uv#10620)) ##### Bug fixes - Avoid reading symlinks during `uv python install` on Windows ([#10639](astral-sh/uv#10639)) - Correct Pyston tag format ([#10580](astral-sh/uv#10580)) - Provide `pyproject.toml` path for parse errors in `uv venv` ([#10553](astral-sh/uv#10553)) - Don't treat `setuptools` and `wheel` as seed packages in uv sync on Python 3.12 ([#10572](astral-sh/uv#10572)) - Fix git-tag cache-key reader in case of slashes ([#10467](astral-sh/uv#10467)) ([#10500](astral-sh/uv#10500)) - Include build tag in rendered wheel filenames ([#10599](astral-sh/uv#10599)) - Patch embedded install path for Python dylib on macOS during `python install` ([#10629](astral-sh/uv#10629)) - Read cached registry distributions when `--config-settings` are present ([#10578](astral-sh/uv#10578)) - Show resolver hints for packages with markers ([#10607](astral-sh/uv#10607)) ##### Documentation - Add meta titles to documents in guides, excluding integration documents ([#10539](astral-sh/uv#10539)) - Remove `build-system` from example workspace rot ([#10636](astral-sh/uv#10636)) ##### Preview features - Make build backend type annotations more generic ([#10549](astral-sh/uv#10549)) ### [`v0.5.18`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0518) [Compare Source](astral-sh/uv@0.5.17...0.5.18) ##### Bug fixes - Avoid forking for identical markers ([#10490](astral-sh/uv#10490)) - Avoid panic in `uv remove` when only comments exist ([#10484](astral-sh/uv#10484)) - Revert "improve shell compatibility of venv activate scripts ([#10397](astral-sh/uv#10397))" ([#10497](astral-sh/uv#10497)) ### [`v0.5.17`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0517) [Compare Source](astral-sh/uv@0.5.16...0.5.17) This release includes support for generating lockfiles from scripts based on inline metadata, as defined in PEP 723. By default, scripts remain unlocked, and must be locked explicitly with `uv lock --script /path/to/script.py`, which will generate a lockfile adjacent to the script (e.g., `script.py.lock`). Once generated, the lockfile will be respected (and updated, if necessary) across `uv run --script`, `uv add --script`, and `uv remove --script` invocations. This release also includes support for `uv export --script` and `uv tree --script`. Both commands support PEP 723 scripts with and without accompanying lockfiles. ##### Enhancements - Add support for locking PEP 723 scripts ([#10135](astral-sh/uv#10135)) - Respect PEP 723 script lockfiles in `uv run` ([#10136](astral-sh/uv#10136)) - Update PEP 723 lockfile in `uv add --script` ([#10145](astral-sh/uv#10145)) - Update PEP 723 lockfile in `uv remove --script` ([#10162](astral-sh/uv#10162)) - Add `--script` support to `uv export` for PEP 723 scripts ([#10160](astral-sh/uv#10160)) - Add `--script` support to `uv tree` for PEP 723 scripts ([#10159](astral-sh/uv#10159)) - Add `ls` alias to `uv {tool, python, pip} list` ([#10240](astral-sh/uv#10240)) - Allow reading `--with-requirements` from stdin in `uv add` and `uv run` ([#10447](astral-sh/uv#10447)) - Warn-and-ignore for unsupported `requirements.txt` options ([#10420](astral-sh/uv#10420)) ##### Preview features - Add remaining Python type annotations to build backend ([#10434](astral-sh/uv#10434)) ##### Performance - Avoid allocating for names in the PEP 508 parser ([#10476](astral-sh/uv#10476)) - Fetch concurrently for non-first-match index strategies ([#10432](astral-sh/uv#10432)) - Remove unnecessary `.to_string()` call ([#10419](astral-sh/uv#10419)) - Respect sentinels in package prioritization ([#10443](astral-sh/uv#10443)) - Use `ArcStr` for marker values ([#10453](astral-sh/uv#10453)) - Use `ArcStr` for package, extra, and group names ([#10475](astral-sh/uv#10475)) - Use `matches!` rather than `contains` in `requirements.txt` parsing ([#10423](astral-sh/uv#10423)) - Use faster disjointness check for markers ([#10439](astral-sh/uv#10439)) - Pre-compute PEP 508 markers from universal markers ([#10472](astral-sh/uv#10472)) ##### Bug fixes - Fix `UV_FIND_LINKS` delimiter to split on commas ([#10477](astral-sh/uv#10477)) - Improve `uv tool list` output when tool environment is broken ([#10409](astral-sh/uv#10409)) - Only track markers for compatible versions ([#10457](astral-sh/uv#10457)) - Respect `requires-python` when installing tools ([#10401](astral-sh/uv#10401)) - Visit proxy packages eagerly ([#10441](astral-sh/uv#10441)) - Improve shell compatibility of `venv` activate scripts ([#10397](astral-sh/uv#10397)) - Read publish username from URL ([#10469](astral-sh/uv#10469)) ##### Documentation - Add Lambda layer instructions to AWS Lambda guide ([#10411](astral-sh/uv#10411)) - Add `uv lock --script` to the docs ([#10414](astral-sh/uv#10414)) - Use Windows-specific instructions in Jupyter guide ([#10446](astral-sh/uv#10446)) ### [`v0.5.16`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0516) [Compare Source](astral-sh/uv@0.5.15...0.5.16) ##### Enhancements - Accept full requirements in `uv remove` ([#10338](astral-sh/uv#10338)) ##### Performance - Avoid over-counting versions in batch prefetcher ([#10350](astral-sh/uv#10350)) - Deactivate tracing for version-choosing ([#10351](astral-sh/uv#10351)) - Force a niche into `VersionSmall` ([#10385](astral-sh/uv#10385)) - Optimize `requirements_for_extra` ([#10348](astral-sh/uv#10348)) - Re-enable `zlib-ng` on x86 platforms ([#10365](astral-sh/uv#10365)) - Re-enable zlib-ng on all platforms (except s390x, PowerPC, and FreeBSD) ([#10370](astral-sh/uv#10370)) - Remove `[u64; 4]` from small version to move `Arc` to full version ([#10345](astral-sh/uv#10345)) - Shrink `Dist` from 352 to 288 bytes ([#10389](astral-sh/uv#10389)) - Speed up file pins by removing nested hash map ([#10346](astral-sh/uv#10346)) - Buffer file reads in `serde_json::from_reader` ([#10341](astral-sh/uv#10341)) ##### Bug fixes - Avoid enforcing project-level required version for `uv self` ([#10374](astral-sh/uv#10374)) - Fix Ruff linting warnings from generated template files for extension modules ([#10371](astral-sh/uv#10371)) ##### Documentation - Add AWS Lambda integration guide ([#10278](astral-sh/uv#10278)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

charliermarsh added the performance Potential performance improvement label Jan 10, 2025

charliermarsh requested review from BurntSushi and konstin January 10, 2025 01:07

charliermarsh marked this pull request as ready for review January 10, 2025 01:07

charliermarsh force-pushed the charlie/arc branch from c54e65e to 1a4925f Compare January 10, 2025 01:08

zanieb approved these changes Jan 10, 2025

View reviewed changes

konstin approved these changes Jan 10, 2025

View reviewed changes

BurntSushi approved these changes Jan 10, 2025

View reviewed changes

charliermarsh requested a review from BurntSushi January 10, 2025 17:46

charliermarsh added 12 commits January 10, 2025 14:51

Use Arc for markers

2c5c679

Use CompactStr

e2513bf

Use FlexStr

75a58bf

Use arcstr

4de0639

Revert "Use arcstr"

7c11b59

This reverts commit a5da1d8.

Revert "Use FlexStr"

787382e

This reverts commit f61326b.

Revert "Use CompactStr"

2d51b31

This reverts commit 6bb5cc8.

Reverts

7c81ecb

Revert "Reverts"

9a5db95

This reverts commit 7c81ecb.

Revert "Revert "Use CompactStr""

ec6020f

This reverts commit 2d51b31.

Revert "Revert "Use FlexStr""

50a4e90

This reverts commit 787382e.

Revert "Revert "Use arcstr""

e13a977

This reverts commit 7c11b59.

charliermarsh force-pushed the charlie/arc branch from 1a4925f to da26bcb Compare January 10, 2025 19:58

Clean up

8521770

charliermarsh force-pushed the charlie/arc branch from da26bcb to 8521770 Compare January 10, 2025 19:58

charliermarsh changed the title ~~Use Arc<str> for marker values~~ Use ArcStr for marker values Jan 10, 2025

charliermarsh merged commit 8420195 into main Jan 10, 2025
81 checks passed

charliermarsh deleted the charlie/arc branch January 10, 2025 20:15

BrewTestBot mentioned this pull request Jan 10, 2025

uv 0.5.17 Homebrew/homebrew-core#203891

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use `ArcStr` for marker values #10453

Use `ArcStr` for marker values #10453

charliermarsh commented Jan 10, 2025 •

edited

Loading

zanieb left a comment

konstin commented Jan 10, 2025

BurntSushi left a comment

charliermarsh commented Jan 10, 2025

BurntSushi commented Jan 10, 2025 •

edited

Loading

charliermarsh commented Jan 10, 2025

charliermarsh commented Jan 10, 2025

BurntSushi commented Jan 10, 2025

charliermarsh commented Jan 10, 2025

Use ArcStr for marker values #10453

Use ArcStr for marker values #10453

Conversation

charliermarsh commented Jan 10, 2025 • edited Loading

Summary

zanieb left a comment

Choose a reason for hiding this comment

konstin commented Jan 10, 2025

BurntSushi left a comment

Choose a reason for hiding this comment

charliermarsh commented Jan 10, 2025

BurntSushi commented Jan 10, 2025 • edited Loading

charliermarsh commented Jan 10, 2025

charliermarsh commented Jan 10, 2025

BurntSushi commented Jan 10, 2025

charliermarsh commented Jan 10, 2025

Use `ArcStr` for marker values #10453

Use `ArcStr` for marker values #10453

charliermarsh commented Jan 10, 2025 •

edited

Loading

BurntSushi commented Jan 10, 2025 •

edited

Loading