Allow additional arguments for sum and max comprehensions #12364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
commented
Jul 17, 2024
| call.args[0].comma = Some(Comma { | ||
| whitespace_after: ParenthesizableWhitespace::default(), | ||
| ..comma.clone() | ||
| }); |
There was a problem hiding this comment.
Without this, we were (1) dropping commas in some tests (see fixture changes), and (2) adding an extra space after the comma when fixing sum([x.val for x in bar], 0) (not sure why?).
There was a problem hiding this comment.
Hmm, I don't remember why this was None but this seems correct to me. It might've been some weird comment placement, not sure though.
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| C419 | 6 | 6 | 0 | 0 | 0 |
AlexWaygood
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These can have other arguments, so it seems wrong to gate on single argument here.
Closes #12358.