Two step source separation #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d deviation as an oprion.
…rating the two step source separation recipe. Specifically, for the two step process a new method callback is called which has a modular structure and does not intervene with the other callback methods existing.
…opriate format and docs. Moreover we add a simpler block for dilated separable convolutions without skip connections.
…zation for the filterbank and the separator.
…ses for loading the appropriate module parts and encoding directories paths.
mpariente
reviewed
Mar 27, 2020
…d deviation as an oprion.
…rating the two step source separation recipe. Specifically, for the two step process a new method callback is called which has a modular structure and does not intervene with the other callback methods existing.
…opriate format and docs. Moreover we add a simpler block for dilated separable convolutions without skip connections.
…zation for the filterbank and the separator.
…ses for loading the appropriate module parts and encoding directories paths.
…d deviation as an oprion.
…opriate format and docs. Moreover we add a simpler block for dilated separable convolutions without skip connections.
…zation for the filterbank and the separator.
…ses for loading the appropriate module parts and encoding directories paths.
…rating the two step source separation recipe. Specifically, for the two step process a new method callback is called which has a modular structure and does not intervene with the other callback methods existing.
… error as requested
…problem with a background running server job
…ive encoder/decoder
…ore code as specified. However, in a next PR we can move the two-step tdcn inside the main block codebase as it is almost ready
mpariente
reviewed
Apr 9, 2020
| @@ -52,24 +51,29 @@ def forward(self, *args, **kwargs): | |||
| """ | |||
| return self.model(*args, **kwargs) | |||
|
|
|||
| def common_step(self, batch, batch_nb): | |||
| def common_step(self, batch, batch_nb, train=True): | |||
There was a problem hiding this comment.
I guess you cherry-picked three of my commits to have the new System.
This is bad habit for two reasons
- The changes will be asociated with this PR (wrong history)
- If you make a small change on this new version of the file, it is not as obvious to see
There are two ways to deal with this - Rebase master and force-push
- Merge master into your branch
Because we squash PRs before merging, I prefer the second method.
There was a problem hiding this comment.
Oh I am sorry man this was a mistake
mpariente
approved these changes
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrating the two-step source separation in asteroid.