Fix typos in 02_Filterbank.ipynb
#527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hihunjin
commented
Jul 8, 2021
| @@ -126,8 +126,7 @@ | |||
| } | |||
| ], | |||
| "source": [ | |||
| "from asteroid.filterbanks import STFTFB\n", | |||
| "from asteroid.filterbanks.transforms import take_mag\n", | |||
There was a problem hiding this comment.
This line is redundant.
hihunjin
commented
Jul 8, 2021
| @@ -193,7 +192,7 @@ | |||
| "metadata": {}, | |||
| "source": [ | |||
| "## Making an encoder-decoder pair in one line \n", | |||
| "[`make_enc_dec`](https://github.com/asteroid-team/asteroid/blob/master/asteroid/filterbanks/__init__.py#L12) is a small function that helps making encoder-decoder pairs in an efficient way. Let's see some examples :\n" | |||
| "[`make_enc_dec`](https://github.com/asteroid-team/asteroid-filterbanks/blob/master/asteroid_filterbanks/__init__.py#L14-L70) is a small function that helps making encoder-decoder pairs in an efficient way. Let's see some examples :\n" | |||
There was a problem hiding this comment.
to the asteroid/asteroid-filterbanks repository
|
Thanks for the fix, it's quite useful. Can you had the notebook |
hihunjin
changed the title
asteroid.filterbanks to asteroid_filterbanks with a fixed link02_Filterbank.ipynb
|
@JorisCos does this look good? Thanks 😊 |
|
Looks great ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asteroid.filterbankstoasteroid_filterbankson the colab notebook.Additionally, I changed the link of asteroid_filterbanks from asteroid.filterbanks.
This PR is with the issue "No module named 'asteroid.filterbanks' #525"
Thanks in advance.