Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[src] Beamforming: optimal channel selection #484

Merged
merged 10 commits into from
Apr 26, 2021
Merged

Conversation

mpariente
Copy link
Collaborator

Based on a posteriori SNR from here

image

Still need to enable custom channel selection with integer and torch.Tensor

@mpariente mpariente requested a review from popcornell April 19, 2021 13:56
@mpariente
Copy link
Collaborator Author

I'm unsure about the generic get_reference_mic_idx function.
I think it's useful but maybe it's too obscure?

@popcornell
Copy link
Collaborator

what if we enforce in every beamforming function that the ref_channel is a vector of shape B, M ?
And get_ref_mics converts integer and vector of B integers to that format ?
In that way one could use a DNN to output the ref_channel like in channel selection. I think it is the most flexible thing

@mpariente
Copy link
Collaborator Author

And could this matrix have soft assignments (as opposed to the one-hot-like we have in this PR)?

@mpariente
Copy link
Collaborator Author

A side note:
I might be wrong but not all beamformers can choose the channel right?
GEV for example doesn't, am I mistaken?

@mpariente mpariente merged commit efb95a4 into master Apr 26, 2021
@mpariente mpariente deleted the optimal_channel branch April 26, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants