Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #360 Correct DCCRN RNN #364

Merged
merged 4 commits into from
Nov 30, 2020
Merged

Fix #360 Correct DCCRN RNN #364

merged 4 commits into from
Nov 30, 2020

Conversation

jonashaag
Copy link
Collaborator

No description provided.

@mpariente
Copy link
Collaborator

Looks perfect.
Add a test please.

@jonashaag
Copy link
Collaborator Author

You have an idea how to test it? I mean we could initialise the weights to some constant and then compute the results but maybe there is an easier way?

mpariente
mpariente reviewed Nov 28, 2020
View reviewed changes
Copy link
Collaborator

@mpariente mpariente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested some change.

For the test, maybe forward by hand for a two-layer model and make sure it's what we expect.

asteroid/complex_nn.py Outdated Show resolved Hide resolved
asteroid/complex_nn.py Outdated Show resolved Hide resolved
@jonashaag
Copy link
Collaborator Author

This looks great, thanks for completing.

@mpariente mpariente merged commit 2055f2b into master Nov 30, 2020
@mpariente mpariente deleted the fix-complex-rnn branch November 30, 2020 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpariente mpariente mpariente left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonashaag @mpariente