Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Build with torch-nightly #350

Merged
merged 8 commits into from
Nov 24, 2020
Merged

[CI] Build with torch-nightly #350

merged 8 commits into from
Nov 24, 2020

Conversation

mpariente
Copy link
Collaborator

Ugly, but simple (if it works).

I'd be ok with that for now.

@jonashaag
Copy link
Collaborator

Yes looks ok. Shall we also test with 1.6?

@mpariente
Copy link
Collaborator Author

Yes, let's do that as well

@mpariente
Copy link
Collaborator Author

/rebase

@jonashaag
Copy link
Collaborator

jonashaag commented Nov 24, 2020

Very nice! But why doesn't CI run?

@mpariente
Copy link
Collaborator Author

Don't know..
It's not the first time it happens.

@mpariente
Copy link
Collaborator Author

@jonashaag
Copy link
Collaborator

I've been told it only works with that exact commit message

assert_allclose used to squeeze before the tests I guess. Now it doesn't and the shape was wrong in the test
@mpariente
Copy link
Collaborator Author

I'm wondering if it's necessary to run the tests 6 times

@mpariente mpariente merged commit 81b757b into master Nov 24, 2020
@mpariente mpariente deleted the nighly_tests branch November 24, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants