Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add asteroid-versions script to print installed versions #349

Merged
merged 5 commits into from
Nov 24, 2020

Conversation

jonashaag
Copy link
Collaborator

@jonashaag jonashaag commented Nov 24, 2020

We could use this as for the issue templates.

$ asteroid-versions
Asteroid            0.4.0rc0, Git checkout f7938f3413bb (asteroid-env)
PyTorch             1.7.0+cpu
PyTorch-Lightning   0.9.0

@mpariente
Copy link
Collaborator

Looks great, thanks !
Let's add a test for it and merge it

@jonashaag
Copy link
Collaborator Author

Well it's going to be a mess to test this properly (checking all of the values etc) but how about adding a simple test that checks that the function does anything at all?

@mpariente
Copy link
Collaborator

Yes, just execute it in a test file. Not rigorous unit test 😅

@jonashaag
Copy link
Collaborator Author

Added suggestion for update to issue template, feel free to ignore or change :)

@mpariente mpariente merged commit 0ece5bf into master Nov 24, 2020
@mpariente mpariente deleted the asteroid-env branch November 24, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants