Add unit tests for X3D models which were broken at 5 Oct 2020 commit 3b9d4cf #5828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellypresence
changed the title
|
Please retry analysis of this Pull-Request directly on SonarCloud |
kimkulling
approved these changes
Oct 20, 2024
|
Merged, thanks a lot for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5829
Add unit tests for keyboard and "chevy" models. The currently broken importer provides incorrect number of meshes for these models; the tests reflect the incorrect mesh count, with
TODOs so that when the importer is fixed and the tests begin failing, it will be obvious how to restore working test values