Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed error with trailing zero symbol as placeholder character #4759

Merged
merged 1 commit into from
Oct 23, 2022
Merged

Fixed error with trailing zero symbol as placeholder character #4759

merged 1 commit into from
Oct 23, 2022

Conversation

Let0s
Copy link

@Let0s Let0s commented Oct 18, 2022

Fixed error with \0 symbol in XML structure inside exported collada file, described in #4758

@Let0s Let0s force-pushed the trailing_zero_fix_collada_exporter branch from e4bbf26 to ac87b9c Compare October 19, 2022 06:30
kimkulling
kimkulling approved these changes Oct 23, 2022
View reviewed changes
Copy link
Member

@kimkulling kimkulling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, thanks for the work. I will merge it.

@kimkulling kimkulling merged commit c2967cf into assimp:master Oct 23, 2022
@kimkulling
Copy link
Member

Merged, thanks a lot for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimkulling kimkulling kimkulling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
The Asset-Importer-Lib Kanban Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Let0s @kimkulling