Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to treat warnings as errors #4509

Merged
merged 9 commits into from
May 6, 2022
Merged

Add an option to treat warnings as errors #4509

merged 9 commits into from
May 6, 2022

Conversation

hgdagon
Copy link
Contributor

@hgdagon hgdagon commented Apr 30, 2022

Add an option to treat warnings as errors for finer control.

Copy link
Member

@kimkulling kimkulling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding abouth the default value.

CMakeLists.txt Outdated Show resolved Hide resolved
Copy link
Member

@kimkulling kimkulling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, I will merge it.

@kimkulling kimkulling merged commit 25118d2 into assimp:master May 6, 2022
@kimkulling
Copy link
Member

Merged, thanks a lot for your contribution.

@hgdagon hgdagon deleted the assimp_warnings_as_errors branch May 7, 2022 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants