Avoid setting PBR properties when they are not found on mtl file #4440
Conversation
… are not found on mtl file.
|
I’ll leave it to the core developers to comment, if necessary, on the implementation details. However, the concept expressed with this PR to optionally add the PBR properties based on their presence in the MTL file makes sense to me and shouldn’t impact anyone using a PBR workflow with OBJ. |
| @@ -0,0 +1,29 @@ | |||
| #pragma once | |||
| #pragma once | ||
| #include <assimp/ai_assert.h> | ||
|
|
||
| template <typename T> |
|
Sure, I can check. I'm not really versed with std::optional, never used it before, and just tried to use something similar to STEPFile.h::Maybe, in case you were all used to this. But yes, I can change it if you prefer to use std. |
|
|
|
That might be a disadvantage, at least for this minimal use case. |
|
At the moment we have c++11 as our minimum. So I guess adding this class makes sense for me. Thanks a lot for checking this out. |
|
Merged, thanks a lot for your contribution. |
This comes from #4424.
Metallic/roughness/sheen/clearcoat properties should only be added to the material if they appear on .mtl file.
Pinging @errissa here, feel free to suggest/change if you find anything odd.