Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 2603 #2655

Merged
merged 1 commit into from
Sep 16, 2019
Merged

Issue 2603 #2655

merged 1 commit into from
Sep 16, 2019

Conversation

PascalGilbraith
Copy link
Contributor

@PascalGilbraith PascalGilbraith commented Sep 15, 2019 •
edited
Loading

Closes #2603
Normal face indices added to end of already resized vector, so normal faces did not match position faces.
Use vector index rather than push.

@PascalGilbraith
Issue 2603
7f79189 
Normal face indices added to end of already resized vector, so normal faces did not match position faces.
Use vector index rather than push.
@kimkulling kimkulling merged commit 7f3b33d into assimp:master Sep 16, 2019
@kimkulling
Copy link
Member

Merged, thanks a lot for the contribution.

@PascalGilbraith PascalGilbraith deleted the issue_2603 branch September 16, 2019 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimkulling kimkulling kimkulling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

corrupted normals loaded from .x file
2 participants
@PascalGilbraith @kimkulling