Add a serverless sample #39
Conversation
samples/Serverless/ClientHandler.cs
Outdated
| _connection.On<string, string>("SendMessage", | ||
| (string server, string message) => | ||
| { | ||
| Console.WriteLine($"Received message from server {server}: {message}"); |
|
|
||
| public async Task StartAsync() | ||
| { | ||
| await _connection.StartAsync(); |
There was a problem hiding this comment.
When will _connection be disposed?
There was a problem hiding this comment.
When the program terminate.
There was a problem hiding this comment.
We should dispose it gracefully. We can pass in a cancellation token and request cancel once we read any input from command line.
There was a problem hiding this comment.
cancellation token in startasync seems no use for disposing connection, we can call DisposeAsync explicitly after we get input
samples/Serverless/Serverless.csproj
Outdated
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.AspNetCore.SignalR.Client" Version="1.0.0" /> | ||
| <PackageReference Include="Microsoft.Azure.SignalR" Version="1.0.0-preview1-10011" /> |
There was a problem hiding this comment.
Use 1.0.0-* to retrieve the latest version.
samples/Serverless/ClientHandler.cs
Outdated
| @@ -0,0 +1,46 @@ | |||
| // Copyright (c) .NET Foundation. All rights reserved. | |||
| // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. | |||
|
|
||
| private void ShowHelp() | ||
| { | ||
| Console.WriteLine("*********Usage*********\n" + |
There was a problem hiding this comment.
Consider using verbatim string.
Also the format can be better.
There was a problem hiding this comment.
If using verbatim string the format will be a little weird because there must be no indent from the second line
samples/Serverless/README.md
Outdated
| Azure SignalR Service Serverless Sample | ||
| ================================= | ||
|
|
||
| This sample demonstrate a serverless Azure SignalR Service. One console app call REST API in service to send message and another console app work as a client to receive message through listening the service. |
There was a problem hiding this comment.
->
This sample is a console app showing the use of Azure SignalR Service in server-less pattern. It provides two modes:
- Server Mode: use simple commands to call Azure SignalR Service REST API.
- Client Mode: connect to Azure SignalR Service and receive messages from server.
Also you can find how to generate an access token to authenticate with Azure SignalR Service.
samples/Serverless/Program.cs
Outdated
| app.FullName = "Azure SignalR Serverless Sample"; | ||
| app.HelpOption("--help"); | ||
|
|
||
| var connectionString = app.Option("-c|--connectionstring", "Set ConnectionString", CommandOptionType.SingleValue, true); |
There was a problem hiding this comment.
Allow connection string to be set in user secrets?
There was a problem hiding this comment.
Do we also need to support AzureConnectionString in appsetting.json
There was a problem hiding this comment.
We can skip appsetting.json.
| ### Start a client | ||
|
|
||
| ``` | ||
| Serverless.exe client <ClientName> -c "<ConnectionString>" -h <HubName> |
There was a problem hiding this comment.
Can we use dotnet run --no-build ...?
There was a problem hiding this comment.
Yes, I've updated README
Add a serverless sample to demonstrate how to use service with rest api call and generate access token.