Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate adapters session logic from core package #496

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

twsouthwick
Copy link
Contributor

No description provided.

Comment on lines -55 to -58
<Reference Include="System.Configuration" />

<PackageReference Include="System.Text.Json" Version="6.0.0" />
<PackageReference Include="System.Threading.Channels" Version="6.0.0" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main goal was to remove these dependencies? What problems did we expect these to cause people?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That the general HttpContext adapter usage could be done without a bunch of new dependencies. People often complain when their packages.config ends up with a ton of new packages (which is what this will do to a .NET 4.7.2 app). Since they may not need the session stuff, this can be a pay-for-play thing.

@twsouthwick twsouthwick merged commit 16f8ba2 into main Apr 20, 2022
@twsouthwick twsouthwick deleted the tasou/session-library branch April 20, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants