Moved get_type_hints() to the 3.9 level #298
Conversation
| @@ -434,7 +434,6 @@ def _fix_file( | |||
| 'typing_extensions=typing:TYPE_CHECKING', | |||
| 'typing_extensions=typing:Text', | |||
| 'typing_extensions=typing:Type', | |||
| 'typing_extensions=typing:get_type_hints', | |||
There was a problem hiding this comment.
please read the PR I linked you to and the comment directly above this
There was a problem hiding this comment.
Are you referring to a comment in the code, or a comment in the linked PR? Either way I'm not sure what you mean, but I did make one change I noticed that the linked PR did too.
There was a problem hiding this comment.
the comment in the code that says "this is generated" -- aka you shouldn't edit it manually
There was a problem hiding this comment.
I've removed the changes to generated code.
|
you should change the generator, then run the generator, then put the generated code into the source |
reorder_python_imports.py
Outdated
| REPLACES[(3, 11)].update(( | ||
| 'typing_extensions=typing:NamedTuple', | ||
| 'typing_extensions=typing:TypedDict', | ||
| 'typing_extensions=typing:final', | ||
| 'typing_extensions=typing:overload', | ||
| )) |
There was a problem hiding this comment.
like the other PR -- can you remove this from the output until 3.11 final has landed
This function gained an extra parameter, "include_extras", in Python 3.9, and this parameter is provided by the typing_extensions implementation.
|
Thanks! |
This function gained an extra parameter, "include_extras", in Python 3.9, and this parameter is provided by the typing_extensions implementation.