Skip to content
This repository has been archived by the owner on Feb 16, 2020. It is now read-only.

Method.Update Function Not called with multiple Tulip Indicators #2548

Closed
@bvanhou

Description

Note: this is the technical bug tracker, please use other platforms for getting support and starting a (non technical) discussion. See the getting help page for details.

I'm submitting a ...
[X ] bug report
[ ] question about the decisions made in the repository

newest Stabe build

Action taken (what you did)
Attempted to add multiple tulip indicators (any tulip indicators).
Then run strategy via command line.

Expected result (what you hoped would happen)
The method.update function will be called.

Actual result (unexpected outcome)
The method.update function is not called.

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, etc)

You can mix and match any of the tulip indicators. Declaring multiple of them just does not work.

this.addTulipIndicator('_mfi', 'mfi', {optInTimePeriod: 14});
  this.addTulipIndicator('_bb', 'bbands', {optInTimePeriod: 20, optInNbStdDevs:2});
  this.addTulipIndicator('_stoch', 'stoch', {optInFastKPeriod: 3, optInSlowKPeriod: 3, optInSlowDPeriod: 3});
  this.addTulipIndicator('_macd', 'macd', { optInFastPeriod: 10, optInSlowPeriod: 21, optInSignalPeriod: 9});

Activity

askmike

askmike commented on Sep 19, 2018

@askmike
Owner

Thanks for the report, will check asap.

bvanhou

bvanhou commented on Sep 19, 2018

@bvanhou
Author

Thanks, this unfortunately is a big show stopper. I just tested and found that the issue occurs in v0.6.6 and not v0.6.5. Just verified.

#if this helps
config.tradingAdvisor = {
enabled: true,
method: 'tulip-multi-strat',
candleSize: 1,
historySize: 10,
}

**Note: Issue will always occur doesnt matter what you choose

eusorov

eusorov commented on Sep 30, 2018

@eusorov
Contributor

I can confirm, in standalone mode nothing happens but with UI-Mode it works like expected.

Added the 4 tulip indicators to tulip-multi-strat.js from above and the update method is called as expected.

In general it is probably difficult to see logs in console, because log.js prevents in UI-mode. But if you add to _write method a console.log(message); like this:

Log.prototype = {
   _write: function(method, args, name) {
   ...
    console.log(message);
    this.output[method](message);
}

than you see that the update method is called.

added a commit that references this issue on Oct 3, 2018

bugfix askmike#2548 if no strategy.historySize found, get from tradin…

eusorov

eusorov commented on Oct 3, 2018

@eusorov
Contributor

In UI mode there is :
candleSize = 1
historySize = 4

But in standalone mode, in sample-config.js there is no such settings for tulip-multi-strat.

With the bugfix we check if historySize was provided or not.

added a commit that references this issue on Oct 8, 2018

bugfix #2548 if no strategy.historySize found, than get it from tradi…

mentioned this in 2 pull requests on Oct 25, 2018
stale

stale commented on Dec 2, 2018

@stale

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. If you feel this is very a important issue please reach out the maintainer of this project directly via e-mail: gekko at mvr dot me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Method.Update Function Not called with multiple Tulip Indicators · Issue #2548 · askmike/gekko