Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Print warning if plugin does not support keeping downloads, if configured #1644

Merged
merged 1 commit into from
Jan 9, 2024
Merged

fix: Print warning if plugin does not support keeping downloads, if configured #1644

merged 1 commit into from
Jan 9, 2024

Conversation

hyperupcall
Copy link
Contributor

@hyperupcall hyperupcall commented Sep 17, 2023 •
edited
Loading

Summary

Fixes #922

@hyperupcall hyperupcall changed the title wip Print warning if always_keep_download = yes, but plugin does not support it Sep 17, 2023
@jthegedus
Copy link
Contributor

Nice.

Since this would run across many plugins, so logging the specific plugin that doesn't support this would be ideal.

@hyperupcall hyperupcall force-pushed the hyperupcall-keep-download-message branch 2 times, most recently from d65c562 to 40bd4e3 Compare September 19, 2023 08:51
@hyperupcall hyperupcall changed the title Print warning if always_keep_download = yes, but plugin does not support it fix: Print warning if plugin does not support keeping downloads, if configured Sep 19, 2023
@hyperupcall hyperupcall force-pushed the hyperupcall-keep-download-message branch from 40bd4e3 to 0026e8a Compare September 19, 2023 08:53
@hyperupcall hyperupcall force-pushed the hyperupcall-keep-download-message branch from 0026e8a to 28c8db0 Compare September 19, 2023 09:04
@hyperupcall hyperupcall marked this pull request as ready for review September 19, 2023 09:20
@hyperupcall hyperupcall requested a review from a team as a code owner September 19, 2023 09:20
@hyperupcall
Copy link
Contributor Author

hyperupcall commented Sep 27, 2023 •
edited
Loading

This is ready to be merged @jthegedus

jthegedus
jthegedus approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@jthegedus jthegedus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, cheers!

@jthegedus jthegedus merged commit 19515ed into asdf-vm:master Jan 9, 2024
7 checks passed
@github-actions github-actions bot mentioned this pull request Jan 9, 2024
Merged
@BrewTestBot BrewTestBot mentioned this pull request Jan 19, 2024
Merged
Stratus3D pushed a commit that referenced this pull request Dec 16, 2024
@hyperupcall @Stratus3D
fix: warn if plugin does not support keeping downloads if configured (#…
b000882 
…1644)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jthegedus jthegedus jthegedus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve user experience when using always_keep_download = yes
2 participants
@hyperupcall @jthegedus