Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nushell asdf plugin list all does not list all plugins #1501

Closed
acidghost opened this issue Mar 16, 2023 · 0 comments · Fixed by #1502
Closed

Nushell asdf plugin list all does not list all plugins #1501

acidghost opened this issue Mar 16, 2023 · 0 comments · Fixed by #1502
Labels
bug

Comments

@acidghost
Copy link
Contributor

Describe the Bug

Running asdf plugin list all in Nushell does not list all plugins because the regex is broken and won't work for links that start with https or don't end with .git:

asdf/asdf.nu

Line 102 in 0adc6c1

let template = '(?P<name>.+)\s+?(?P<installed>[*]?)(?P<repository>(?:git|http).+\.git)'

A fix for the regex could be: (?P<name>.+)\s+?(?P<installed>[*]?)(?P<repository>(?:git|http|https).+). The .git does not seem to be required by git clone (tested on git version 2.40.0).

Steps to Reproduce

Just run asdf plugin list all in Nushell.

Expected Behaviour

It should print the whole list of plugins.

Actual Behaviour

Stops on the first line that does not match the regex.

Environment

OS:
Darwin acidghost-MBP.local 22.3.0 Darwin Kernel Version 22.3.0: Mon Jan 30 20:38:37 PST 2023; root:xnu-8792.81.3~2/RELEASE_ARM64_T6000 arm64

SHELL:
zsh 5.8.1 (x86_64-apple-darwin22.0)

ASDF VERSION:
v0.11.2

ASDF ENVIRONMENT VARIABLES:
ASDF_DIR=/Users/acidghost/.dotfiles/asdf-vm

ASDF INSTALLED PLUGINS:
golang                       https://github.com/kennyp/asdf-golang.git master f006a12
java                         https://github.com/halcyon/asdf-java.git master 54b7426
julia                        https://github.com/rkyleg/asdf-julia.git master 1788f0f
nodejs                       https://github.com/asdf-vm/asdf-nodejs.git master c9e5df4
perl                         https://github.com/ouest/asdf-perl.git master 4edc8ab
python                       https://github.com/danhper/asdf-python.git master 8505457
ruby                         https://github.com/asdf-vm/asdf-ruby.git master 7a671a2

asdf plugins affected (if relevant)

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: nushell plugin list all (#1501) acidghost/asdf
1 participant
@acidghost