Libpktriggercord #68
Open
Libpktriggercord #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…li will not work correclty for now)
…ed in every other .h
# Conflicts: # pktriggercord-cli.c # pktriggercord-servermode.c # pktriggercord-servermode.h # pktriggercord.c # pslr_model.c
Open
# Conflicts: # .gitignore # .travis.yml # Makefile # pktriggercord-cli.c # pktriggercord-servermode.c # pktriggercord-servermode.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this ?
This PR reworks pktriggercord so that we can build and expose pktriggercord as a static or dynamic library for other projects to plug in.
A fair bit of work have been done to give the Makefile an overhaul to allow this, and almost all methods have been renamed with a standardized naming.
Why ?
While this will be a breaking change for projects that currently use a forked/modified version of pktriggercord, subsequent modifications and fixes will be much easier and quicker to propagate as it could be done by just updating the lib on the target systems rather than reshipping the entire project with the forked code. For instance, indi have a pentax driver that rely on gphotos2 that itself relies on a forked pktriggercord. Another driver has recently come to light by @karlrees who also contributed to this PR, but the it's the same story : it uses a forked and modified version of pktriggercord.
Previously, every single package of the chain had to updated for a simple fix to be applied. No more :)
Left to do
I have absolutely zero knownledge in linux package distribution (I only use them), but I think that a libpktriggercord package is mandatory for the library to be useful.
There is also a couple of opened PRs that we'll need to to manually merge into this one as methods & code have been moved around :)
Breaking changes in this PR
Breaking changes comes from the renaming that has been done all over the place :)
PS : given the breaking changes, I think that version should be bumped to
0.86.0.