Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated text in PyStan schema example to match PyMC3 example #1807

Merged
merged 3 commits into from
Oct 4, 2021
Merged

Updated text in PyStan schema example to match PyMC3 example #1807

merged 3 commits into from
Oct 4, 2021

Conversation

gth158a
Copy link
Contributor

@gth158a gth158a commented Sep 20, 2021

Documentation update.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

canyon289
canyon289 approved these changes Sep 20, 2021
View reviewed changes
Copy link
Member

@canyon289 canyon289 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for #1806 before merging

@roshnaeem
Copy link
Contributor

Hello @gth158a, can you do me a favor? I have made few changes in the related PR #1790. Can you please do one more commit to keep it same as #1790.

Also, i have opened new issues, you can check and work on them as well.

@gth158a
Copy link
Contributor Author

gth158a commented Oct 2, 2021

Hello @gth158a, can you do me a favor? I have made few changes in the related PR #1790. Can you please do one more commit to keep it same as #1790.

Also, i have opened new issues, you can check and work on them as well.

👍 sounds good. Can you assign this ticket to me?

@gth158a
Copy link
Contributor Author

gth158a commented Oct 4, 2021

@roshnaeem we should be good to go here! 🤓

roshnaeem
roshnaeem approved these changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@roshnaeem roshnaeem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @gth158a.

@OriolAbril OriolAbril merged commit 27e4662 into arviz-devs:main Oct 4, 2021
@gth158a
Copy link
Contributor Author

gth158a commented Oct 4, 2021

Thank you so much @gth158a.

My pleasure, @roshnaeem . I am looking forward to start contributing more 👍

@gth158a gth158a deleted the doc/text/pystan_example branch October 4, 2021 17:17
@roshnaeem
Copy link
Contributor

@gth158a, I have created new issues, you can check them. Let me know if you need any help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roshnaeem roshnaeem roshnaeem approved these changes

@canyon289 canyon289 canyon289 approved these changes

Assignees

@gth158a gth158a

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gth158a @roshnaeem @canyon289 @OriolAbril