Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Refitting PyMC3 models with ArviZ #1796

Merged
merged 5 commits into from
Oct 4, 2021
Merged

Updated Refitting PyMC3 models with ArviZ #1796

merged 5 commits into from
Oct 4, 2021

Conversation

roshnaeem
Copy link
Contributor

Description:
Updated the Refitting PyMC3 models with ArviZ part.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@roshnaeem roshnaeem marked this pull request as draft September 13, 2021 11:45
@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #1796 (0c6be2f) into main (283b6eb) will decrease coverage by 3.84%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1796      +/-   ##
==========================================
- Coverage   91.26%   87.42%   -3.85%     
==========================================
  Files         117      117              
  Lines       12451    12451              
==========================================
- Hits        11364    10885     -479     
- Misses       1087     1566     +479     
Impacted Files Coverage Δ
arviz/data/io_pymc3_3x.py 18.18% <0.00%> (-72.06%) ⬇️
arviz/data/io_pystan.py 62.12% <0.00%> (-33.96%) ⬇️
arviz/data/io_cmdstanpy.py 70.68% <0.00%> (-24.76%) ⬇️
arviz/data/io_emcee.py 93.38% <0.00%> (-4.96%) ⬇️
arviz/utils.py 88.88% <0.00%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 283b6eb...0c6be2f. Read the comment docs.

@roshnaeem roshnaeem changed the title WIP-Updated Refitting PyMC3 models with ArviZ Updated Refitting PyMC3 models with ArviZ Sep 14, 2021
@roshnaeem roshnaeem marked this pull request as ready for review September 14, 2021 11:10
Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also same comments as the pystan2 one. the extra comment here is non-actionable general one about how and why to link pages between them

"\n",
"Note how we would generally use `pm.Data` to populate `xyz_data` groups in the InferenceData result, however, given that we need to recompile the model every time, we are consciously skipping this step to speed up the recompilation. "
"Note how we would generally use `pm.Data` to populate `xyz_data` groups in the {ref}`InferenceData <xarray_for_arviz>` result, however, given that we need to recompile the model every time, we are consciously skipping this step to speed up the recompilation. "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't really have the guide available yet, but following up on what we were commenting the other day, given that here we are talking about populating groups of inferencedata using pm.Data which is pymc specific and this page is an advanced one, I would link from here to the pymc3 conversion page once it's created instead of linking to the intro.

@OriolAbril OriolAbril merged commit d21aecb into arviz-devs:main Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants