-
-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Refitting PyMC3 models with ArviZ #1796
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## main #1796 +/- ##
==========================================
- Coverage 91.26% 87.42% -3.85%
==========================================
Files 117 117
Lines 12451 12451
==========================================
- Hits 11364 10885 -479
- Misses 1087 1566 +479
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also same comments as the pystan2 one. the extra comment here is non-actionable general one about how and why to link pages between them
"\n", | ||
"Note how we would generally use `pm.Data` to populate `xyz_data` groups in the InferenceData result, however, given that we need to recompile the model every time, we are consciously skipping this step to speed up the recompilation. " | ||
"Note how we would generally use `pm.Data` to populate `xyz_data` groups in the {ref}`InferenceData <xarray_for_arviz>` result, however, given that we need to recompile the model every time, we are consciously skipping this step to speed up the recompilation. " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't really have the guide available yet, but following up on what we were commenting the other day, given that here we are talking about populating groups of inferencedata using pm.Data
which is pymc specific and this page is an advanced one, I would link from here to the pymc3 conversion page once it's created instead of linking to the intro.
Description:
Updated the Refitting PyMC3 models with ArviZ part.