Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove print statement #1573

Merged
merged 1 commit into from
Feb 22, 2021
Merged

Conversation

psteyer
Copy link
Contributor

@psteyer psteyer commented Feb 19, 2021

Description

Checklist

  • Follows official PR format
  • Includes a sample plot to visually illustrate the changes (only for plot-related functions)
  • New features are properly documented (with an example if appropriate)?
  • Includes new or updated tests to cover the new feature
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

closes #1560

It seemed like we wanted to remove the print statement. If not, let me know and I can change this.
Let me know if this is correct. This is my first PR to an open source library so any feed back would be great!

@OriolAbril
Copy link
Member

Thanks @ous8292! This is great. I have edited the description so it uses one of github keywords and the related issue gets closes automatically, here are the docs on this feature: https://docs.github.com/en/enterprise/2.16/user/github/managing-your-work-on-github/closing-issues-using-keywords#about-issue-references

And tests are failing for some reasons that is not related to this, we will try to find out why and get back to you.

@OriolAbril OriolAbril merged commit 1dc8209 into arviz-devs:main Feb 22, 2021
@OriolAbril
Copy link
Member

Thanks for the contribution @ous8292 !

utkarsh-maheshwari pushed a commit to utkarsh-maheshwari/arviz that referenced this pull request May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debug print left in release version
2 participants