Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo in loo_pit #1418

Merged
merged 5 commits into from
Oct 15, 2020
Merged

fix typo in loo_pit #1418

merged 5 commits into from
Oct 15, 2020

Conversation

OriolAbril
Copy link
Member

@OriolAbril OriolAbril commented Oct 14, 2020 •
edited
Loading

Description

There is a clause of if y_str to use var_name when getting the log_likelihood that corresponds to the observations but then uses y as var_name instead of y_str.

Checklist

  • Follows official PR format
  • Includes new or updated tests to cover the new feature
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #1418 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1418      +/-   ##
==========================================
- Coverage   91.60%   91.57%   -0.03%     
==========================================
  Files         105      105              
  Lines       11090    11090              
==========================================
- Hits        10159    10156       -3     
- Misses        931      934       +3
Impacted Files Coverage Δ
arviz/stats/stats.py 96.05% <100.00%> (-0.17%) ⬇️
arviz/stats/stats_utils.py 94.91% <0.00%> (-0.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86b4aa9...d7ff0ff. Read the comment docs.

@OriolAbril OriolAbril merged commit 99aff55 into master Oct 15, 2020
@OriolAbril OriolAbril deleted the loo_pit branch October 15, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloctavodia aloctavodia aloctavodia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OriolAbril @aloctavodia