Convert all instances of SyntaxWarning to UserWarning #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Command: ```shell $ grep -rl SyntaxWarning . | xargs sed -i '' 's/SyntaxWarning/UserWarning/g' ```
|
LGTM! |
|
LGTM too, should this be added to the changelog? |
|
Yes, this should be added to the changelog. |
|
Thanks @gimbo! |
|
My pleasure! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #1014, by converting every instance of
SyntaxWarningin the codebase intoUserWarning. (There are only 23 instances in the end, not the 54 I initially thought; I don't know how I came up with 54 yesterday when I opened the issue!)For the record, here's the command I ran to do this:
Tests are passing locally in docker following the instructions in
CONTRIBUTING.md, as is pylint.