Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add canary deployment to reaction PRs #3168

Merged
merged 5 commits into from
Feb 19, 2020
Merged

Add canary deployment to reaction PRs #3168

merged 5 commits into from
Feb 19, 2020

Conversation

zephraph
Copy link
Contributor

@zephraph zephraph commented Feb 18, 2020

This uses artsy/orbs#86 to automatically publish canaries from any branch PRs added to reaction.

For some historical context, we've occasionally ran into the need to publish a standalone version of reaction from a PR to be able to use in a review app to test complicated functionality. Updates to the artist app, the experimental app shell, and the styled-components upgrade are all examples of this.

We recently added documentation (#3156) about how to manually trigger a deployment process. Auto already has the ability to do this automatically, but we were blocked by a breaking change update. Given that the update is complete, this PR enables that functionality so we don't have to worry about manually creating canaries.

We'll need to consider if it'll create too much noise for automated PRs like renovate.

📦 Published PR as canary version: 25.11.1-canary.3168.51833.0

✨ Test out this PR locally via:

npm install @artsy/reaction@25.11.1-canary.3168.51833.0
# or 
yarn add @artsy/reaction@25.11.1-canary.3168.51833.0

@artsy-peril artsy-peril bot added the Version: Patch Indicates that this PR should have a patch deploy, usually for bug fixes label Feb 18, 2020
@codecov
Copy link

codecov bot commented Feb 18, 2020

Codecov Report

Merging #3168 into master will decrease coverage by <.1%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #3168     +/-   ##
========================================
- Coverage    82.7%   82.6%   -0.1%     
========================================
  Files         763     763             
  Lines       11430   11430             
  Branches     2260    2260             
========================================
- Hits         9453    9452      -1     
- Misses       1366    1367      +1     
  Partials      611     611

@zephraph zephraph added Version: Trivial This indicates that the PR does not need a deploy and removed Version: Patch Indicates that this PR should have a patch deploy, usually for bug fixes labels Feb 18, 2020
@zephraph zephraph mentioned this pull request Feb 19, 2020
1 task
@zephraph
Copy link
Contributor Author

I'm gonna ship this

🚀

@zephraph zephraph merged commit 1c4c13a into master Feb 19, 2020
@zephraph zephraph deleted the auto-canaries branch February 19, 2020 04:33
@artsyit
Copy link
Contributor

artsyit commented Feb 19, 2020

🚀 PR was released in v25.11.1 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Version: Trivial This indicates that the PR does not need a deploy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants