Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump docker-compose 2.17.2 -> 2.20.3 #371

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Conversation

artsyjian
Copy link
Contributor

We previously upgraded Docker Compose version from 1.25.5 to 2.17.2. It turns out the new version no longer supports this config in Compose file:

service:
   logging:
      driver: none

This config is useful for suppressing logs from containers that log verbosely to STDOUT, such as MongoDB.

Since removing logging: driver: none, Compose folks added an attach option to docker-compose command-line, and it accomplishes the same thing. Later on, they added support for it in Compose file.

attach is quite new and v2.17.2 doesn't support it. This PR upgrades Compose to the latest which does support attach.

@artsyjian artsyjian requested a review from a team August 24, 2023 00:02
Copy link
Contributor

@mc-jones mc-jones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice sleuthing!

@mzikherman
Copy link
Contributor

Yes - thank you!!

@mzikherman mzikherman merged commit 2b5f9b2 into main Aug 24, 2023
@mzikherman mzikherman deleted the artsyjian/compose branch August 24, 2023 16:18
This was referenced Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants