chore(alerts): clean up onyx_artwork_alert_modal_v2 flag and dead code
#13426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandaroop
force-pushed
the
anandaroop/ONYX-680-cleanup-alerts
branch
2 times, most recently
from
5282c56
to
55589b2
Compare
nickskalkin
approved these changes
Feb 6, 2024
|
Too good to be approved once 😄 |
|
Haha thanks! I'll rebase and merge now. |
test: fix mocking for tracking test: update spec to fetch pill data from MP preview rather than artwork
test: update spec to use new edit form
anandaroop
force-pushed
the
anandaroop/ONYX-680-cleanup-alerts
branch
from
55589b2
to
07327eb
Compare
anandaroop
added
the
Squash On Green
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type of this PR is: Chore
This PR solves ONYX-680
Review app: https://onyx-680.artsy.net
Description
Now that v2 alerts have been out in the wild for a while, we are starting to clean up feature flags and dead code.
This PR starts that process with the
onyx_artwork_alert_modal_v2feature flag.Tests are passing; but for extra confidence that this does not introduce any regressions feel free to try out https://onyx-680.artsy.net
(h/t @tam-kis for pairing on the test fixes!)