Fix gem install portability by avoiding a shell feature dependency #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I tested on ubuntu, the `{lib,ext,vendor}` glob feature worked
in the interactive shell, but not in the non-interactive one spawned
by ruby.
dylanahsmith
force-pushed
the
fix-gem-install
branch
from
76409c9 to
d55ffeb
Compare
dylanahsmith
added a commit
to dylanahsmith/memcached
that referenced
this pull request
Apr 7, 2021
casperisfine
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
@casperisfine I tried adding
bundle exec rake installto CI as you suggested in #186 (comment) and it failed. I was able to reproduce the error in on ubuntu and found the source of the problem was the{lib,ext,vendor}shell glob expansion, which didn't work in the shell spawned by ruby.E.g. in macOS I get
but on Ubuntu I get
Solution
The gemspec file generated by
bundle gemavoids this problem by doing file filtering using ruby, so it doesn't depend on what shell features are available.